linux-kernel - Re: [PATCH] mm: slab: Verify the nodeid passed to ____cache_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512775CA.2030603@parallels.com>
Date:	Fri, 22 Feb 2013 17:42:34 +0400
From:	Glauber Costa <glommer@...allels.com>
To:	Aaron Tomlin <atomlin@...hat.com>
CC:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	Rik <riel@...hat.com>
Subject: Re: [PATCH] mm: slab: Verify the nodeid passed to ____cache_alloc_node

On 02/22/2013 02:07 AM, Aaron Tomlin wrote:
> The addition of this BUG_ON should make debugging easier.
> While I understand that this code path is "hot", surely
> it is better to assert the condition than to wait until
> some random NULL pointer dereference or page fault. If the
> caller passes an invalid nodeid, at this stage in my opinion
> it's already a BUG.
If you assert with VM_BUG_ON, it will be active on debugging kernels
only, which I believe is better suited for a hotpath.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/