linux-kernel - Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130222142619.GA11141@gmail.com>
Date:	Fri, 22 Feb 2013 06:26:20 -0800
From:	Kumar amit mehta <gmate.amit@...il.com>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	gregkh@...uxfoundation.org, fmhess@...rs.sourceforge.net,
	hsweeten@...ionengravers.com, dan.carpenter@...cle.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] staging: comedi: drivers: usbduxsigma.c: fix DMA
 buffers on stack

On Fri, Feb 22, 2013 at 10:02:44AM +0000, Ian Abbott wrote:
> On 2013-02-22 06:07, Kumar Amit Mehta wrote:
> >This patch fixes an instance of DMA buffer on stack(being passed to
> >usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
> >
> 
> Looks good here too.
> 
> Reviewed-by: Ian Abbott <abbotti@....co.uk>
> 
> Would you mind doing the same for usbdux.c and usbduxfast.c?
Sure. 
As pointed out by Dan, Do you really want the buffer to be of 16 bytes, as we
are using only the first byte and passing the length as '1' in:
usbduxsub_start, usbduxsub_stop, usbduxfastsub_start, usbduxfastsub_stop ?

~Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/