linux-kernel - Re: question about arch/arm/mach-s3c24xx/irq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130224123849.GH17833@n2100.arm.linux.org.uk>
Date:	Sun, 24 Feb 2013 12:38:49 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	ben-linux@...ff.org, kgene.kim@...sung.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: question about arch/arm/mach-s3c24xx/irq.c

On Sun, Feb 24, 2013 at 12:45:11PM +0100, Julia Lawall wrote:
> The function s3c24xx_irq_map in arch/arm/mach-s3c24xx/irq.c contains the
> code:
> 
>                 parent_irq_data = &parent_intc->irqs[irq_data->parent_irq];
> 		if (!irq_data) {
>                         pr_err("irq-s3c24xx: no irq data found for hwirq %lu\n",
>                                hw);
>                         goto err;
> 		}
> 
> At this point irq_data has already been tested, so the null test on
> irq_data does not look correct.  But I wonder if parent_irq_data could
> ever be null here?

That would be really obscure - because that would require parent_intc to
be a "negative" pointer (to counter-act the indexing by
irq_data->parent_irq).  So it looks to me like the above is redundant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/