linux-kernel - Re: [PATCH 2/2] perf report: Fix build with NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130226114559.GA18877@concordia>
Date:	Tue, 26 Feb 2013 22:46:00 +1100
From:	Michael Ellerman <michael@...erman.id.au>
To:	Feng Tang <feng.tang@...el.com>
Cc:	acme@...radead.org, linux-kernel@...r.kernel.org,
	namhyung.kim@....com, namhyung@...nel.org
Subject: Re: [PATCH 2/2] perf report: Fix build with NO_NEWT=1

On Tue, Feb 26, 2013 at 04:48:50PM +0800, Feng Tang wrote:
> On Tue, Feb 26, 2013 at 04:02:03PM +1100, Michael Ellerman wrote:
> > Commit ad0de09 "Enable the runtime switching of perf data file" broke
> > the build with NO_NEWT=1:
> > 
> >     CC builtin-report.o
> > builtin-report.c: In function '__cmd_report':
> > builtin-report.c:479:15: error: 'K_SWITCH_INPUT_DATA' undeclared (first use in this function)
> > builtin-report.c:479:15: note: each undeclared identifier is reported only once for each function it appears in
> > builtin-report.c: In function 'cmd_report':
> > builtin-report.c:823:13: error: 'K_SWITCH_INPUT_DATA' undeclared (first use in this function)
> > make: *** [builtin-report.o] Error 1
> > 
> > Fix it by adding a dummy definition of K_SWITCH_INPUT_DATA.
> > 
> > Signed-off-by: Michael Ellerman <michael@...erman.id.au>
> > ---
> >  tools/perf/util/hist.h |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
> > index 609a115..226a4ae 100644
> > --- a/tools/perf/util/hist.h
> > +++ b/tools/perf/util/hist.h
> > @@ -210,6 +210,7 @@ static inline int script_browse(const char *script_opt __maybe_unused)
> >  
> >  #define K_LEFT  -1000
> >  #define K_RIGHT -2000
> > +#define K_SWITCH_INPUT_DATA -3000
> 
> Both patches look good to me, thanks for the fix. But can we use
> a better value? -1000, -2000 looks a little awkward.

Better how? I'm not bothered what the values are, I was just trying to
prevent the same bug happening again by shifting the values out of the
-ERRNO range - which goes to ~130.

cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/