linux-kernel - Re: [PATCH 2/2] f2fs: introduce readahead mode of node pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Feb 2013 20:52:18 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] f2fs: introduce readahead mode of node pages

> @@ -434,7 +434,7 @@ int get_dnode_of_data(struct dnode_of_data *dn, pgoff_t
> index, int ro)
>  			alloc_nid_done(sbi, nids[i]);
>  			mutex_unlock_op(sbi, NODE_NEW);
>  			done = true;
> -		} else if (ro && i == level && level > 1) {
> +		} else if (mode == LOOKUP_NODE_RA && i == level && level > 1) {
>  			npage[i] = get_node_page_ra(parent, offset[i - 1]);
>  			if (IS_ERR(npage[i])) {
>  				err = PTR_ERR(npage[i]);

Hi Jaegeuk.
There is no LOOKUP_NODE usage in this patch.
I think that we can use LOOKUP_NODE flag instead of done(bool)  like this.
 if (mode == LOOKUP_NODE)

Thanks.
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index b235215..6b82e20 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -247,7 +247,7 @@ static void do_recover_data(struct f2fs_sb_info *sbi,
> struct inode *inode,
>  		end = start + ADDRS_PER_BLOCK;
>
>  	set_new_dnode(&dn, inode, NULL, NULL, 0);
> -	if (get_dnode_of_data(&dn, start, 0))
> +	if (get_dnode_of_data(&dn, start, ALLOC_NODE))
>  		return;
>
>  	wait_on_page_writeback(dn.node_page);
> --
> 1.8.1.3.566.gaa39828
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/