linux-kernel - Re: [RFC/RFT][PATCH 1/3] regulator: core: Add enable_pulldown flag to indicate pulldown on EN input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130301092142.GS25302@opensource.wolfsonmicro.com>
Date:	Fri, 1 Mar 2013 17:22:12 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Haojian Zhuang <haojian.zhuang@...il.com>,
	"Jett.Zhou" <jtzhou@...vell.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC/RFT][PATCH 1/3] regulator: core: Add enable_pulldown flag
 to indicate pulldown on EN input

On Fri, Feb 15, 2013 at 05:19:21PM +0800, Axel Lin wrote:
> Add enable_pulldown flag to indicate pulldown on EN input when using
> regulator_enable_regmap and friends APIs.

> -	return (val & rdev->desc->enable_mask) != 0;
> +	if (rdev->desc->enable_pulldown)
> +		return (val & rdev->desc->enable_mask) == 0;
> +	else
> +		return (val & rdev->desc->enable_mask) != 0;

Pulldown isn't the word here...  it's saying that enable is inverted,
not that it's pulled down.  Pulling something down is more an electrical
engineering thing saying what the default value for a signal is if it's
not otherwise driven, it doesn't really make sense in terms of a
register value.

Something like enable_active_low or enable_invert?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)