linux-kernel - Re: [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZMxBGd-Tee1DjKZZLOx5kwxJ5GRmjZT7jZcGAR594WSg@mail.gmail.com>
Date:	Fri, 1 Mar 2013 10:23:42 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	leroy christophe <christophe.leroy@....fr>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org,
	Patrick Vasseur <patrick.vasseur@....fr>
Subject: Re: [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver

On Fri, Mar 1, 2013 at 7:29 AM, leroy christophe
<christophe.leroy@....fr> wrote:
> Le 01/03/2013 01:43, Linus Walleij a écrit :
>
>> On Fri, Feb 22, 2013 at 10:26 AM, Christophe Leroy
>> <christophe.leroy@....fr> wrote:
>>
>>> This patch allows the use of the MAX730x Driver on systems using
>>> the Open Firmware platform format
>>>
>>> Signed-off-by: Patrick Vasseur <patrick.vasseur@....fr>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
>>
>> (...)
>>>
>>>          /* bits_per_word cannot be configured in platform data */
>>> -       spi->bits_per_word = 16;
>>> +       if (spi->dev.platform_data)
>>> +               spi->bits_per_word = 16;
>>
>> What about just fixing so you *can* specify that instead?
>> The comment looks more like a FIXME to me.
>
> Euh, ok, why not. But here the purpose of my patch is to allow using this
> driver with of_platform in addition to platform.
> This FIXME is not mine, it was already existing in that driver.
> As of_platform can configure bits per word, the only thing I did is to add a
> test in order to not apply this FIXME on the of_platform case.
>
> Do you think my patch is not acceptable like this ?

No big deal.

I was just taking this opportunity to try to push out some driver
maintenance, that's what subsystem maintainers do you know...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/