linux-kernel - Re: [PATCH] USB: storage: fix Huawei mode switching regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878v63ru2i.fsf@nemi.mork.no>
Date:	Mon, 04 Mar 2013 17:47:01 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	fangxiaozhi@...wei.com, zihan@...wei.com, Lin.Lei@...wei.com,
	Greg KH <gregkh@...uxfoundation.org>, neil.yi@...wei.com,
	wangyuhua@...wei.com, huqiao36@...wei.com, balbi@...com,
	mdharm-usb@...-eyed-alien.net, sebastian@...akpoint.cc,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] USB: storage: fix Huawei mode switching regression

Ben Hutchings <ben@...adent.org.uk> writes:
> On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote:
> [...]
>> In-kernel mode switching was deprecated years ago with the
>> development of the more user friendly userspace alternatives. The
>> existing list of devices in usb-storage was only kept to prevent
>> breaking already working systems.  The long term plan is to remove
>> the list, not to add to it. Ref:
>> http://permalink.gmane.org/gmane.linux.usb.general/28543
> [...]
>
> Can you add a comment to this effect?

In the table in unusual_devs.h, you mean?  Sure, I can do that.

But it feels a bit strange since I can only quote and/or refer to what
Matthew and Greg said about the issue years ago.  Putting a comment in
the code to remind the current maintainers about their own statements
could be considered out of line?  Or is this appropriate here?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/