linux-kernel - Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK5ve-+FTv1OTfJozs_sy7B0Zd6SzzBOU_1En4AMQCw1RZjprw@mail.gmail.com>
Date:	Tue, 5 Mar 2013 11:03:52 -0800
From:	Bryan Wu <cooloney@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	patches@...nsource.wolfsonmicro.com, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> Provide some trace, though the hardware is most likely non-functional if
> this happens.
>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/leds/leds-wm8350.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c
> index ed15157..86bdab3 100644
> --- a/drivers/leds/leds-wm8350.c
> +++ b/drivers/leds/leds-wm8350.c
> @@ -129,7 +129,11 @@ static void wm8350_led_disable(struct wm8350_led *led)
>         ret = regulator_disable(led->isink);
>         if (ret != 0) {
>                 dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
> -               regulator_enable(led->dcdc);
> +               ret = regulator_enable(led->dcdc);
> +               if (ret != 0) {
looks like we don't need this bracket here.

> +                       dev_err(led->cdev.dev, "Failed to reenable DCDC: %d\n",
> +                               ret);
> +               }
ditto.

Thanks,
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/