linux-kernel - Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130306045534.GE4896@opensource.wolfsonmicro.com>
Date:	Wed, 6 Mar 2013 12:55:37 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Bryan Wu <cooloney@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	patches@...nsource.wolfsonmicro.com, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: wm8350: Complain if we fail to reenable DCDC

On Tue, Mar 05, 2013 at 11:03:52AM -0800, Bryan Wu wrote:
> On Fri, Mar 1, 2013 at 11:40 PM, Mark Brown

> >         if (ret != 0) {
> >                 dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
> > -               regulator_enable(led->dcdc);
> > +               ret = regulator_enable(led->dcdc);
> > +               if (ret != 0) {
> looks like we don't need this bracket here.
> 
> > +                       dev_err(led->cdev.dev, "Failed to reenable DCDC: %d\n",
> > +                               ret);
> > +               }
> ditto.

It's not required but since it's inside a small but multi-line block
there's the whole thing about including braces at all levels for
clarity.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)