linux-kernel - Re: mfd: omap-usb-host: bug fix for 3.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51370D53.9060100@ti.com>
Date:	Wed, 6 Mar 2013 11:33:07 +0200
From:	Roger Quadros <rogerq@...com>
To:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>
CC:	Roger Quadros <rogerq@...com>, "Balbi, Felipe" <balbi@...com>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	"tony@...mide.com" <tony@...mide.com>
Subject: Re: mfd: omap-usb-host: bug fix for 3.9

Hi Samuel,

On 02/27/2013 04:02 PM, Roger Quadros wrote:
> Hi Samuel,
> 
> One of my patch that I sent for 3.9 introduces a bug that fails to
> update the port mode hostconfig register. Because of that, the port modes will
> always be 0 (i.e. EHCI PHY mode) and other modes will not work. PHY mode will
> work, so beagle/panda have no issues.
> 
> Since my hardware setup uses only PHY mode, I couldn't catch this problem earlier.
> 
> Below is the fix.

Gentle reminder to pick this for 3.9-rc2. Thanks.

cheers,
-roger

> 
>>>From 82466757a212bd8b54d806c9d56b1acccbd4d464 Mon Sep 17 00:00:00 2001
> From: Roger Quadros <rogerq@...com>
> Date: Wed, 27 Feb 2013 15:19:24 +0200
> Subject: [PATCH] mfd: omap-usb-host: Actually update hostconfig
> 
> The helper functions omap_usbhs_rev1_hostconfig()
> and omap_usbhs_rev2_hostconfig() don't write into
> the hostconfig register. Make sure that we write
> the return value into the hostconfig register.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> ---
>  drivers/mfd/omap-usb-host.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 6b5edf6..4febc5c 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -460,15 +460,15 @@ static void omap_usbhs_init(struct device *dev)
>  
>  	switch (omap->usbhs_rev) {
>  	case OMAP_USBHS_REV1:
> -		omap_usbhs_rev1_hostconfig(omap, reg);
> +		reg = omap_usbhs_rev1_hostconfig(omap, reg);
>  		break;
>  
>  	case OMAP_USBHS_REV2:
> -		omap_usbhs_rev2_hostconfig(omap, reg);
> +		reg = omap_usbhs_rev2_hostconfig(omap, reg);
>  		break;
>  
>  	default:	/* newer revisions */
> -		omap_usbhs_rev2_hostconfig(omap, reg);
> +		reg = omap_usbhs_rev2_hostconfig(omap, reg);
>  		break;
>  	}
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/