linux-kernel - Re: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130307154033.GU119376@redhat.com>
Date:	Thu, 7 Mar 2013 10:40:33 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	anish singh <anish198519851985@...il.com>
Cc:	akpm@...ux-foundation.org, mingo@...nel.org,
	chuansheng.liu@...el.com, paulmck@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [Watchdog][Trivial] Added comments to explain
 watchdog_disabled variable

On Wed, Mar 06, 2013 at 05:17:04PM +0530, anish singh wrote:
> On Tue, Feb 19, 2013 at 2:18 AM, Don Zickus <dzickus@...hat.com> wrote:
> > On Sat, Feb 16, 2013 at 05:44:09PM +0530, anish kumar wrote:
> >> From: anish kumar <anish198519851985@...il.com>
> >>
> >> This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold.
> >> Uses are:
> >> 1. Check if smpboot_register_percpu_thread function passed.
> >> 2. Makes sure that user enables and disables the watchdog in sequence
> >>    i.e. enable watchdog->disable watchdog->enable watchdog
> >>    Unlike enable watchdog->enable watchdog which is wrong.
> >>
> >> Signed-off-by: anish kumar <anish198519851985@...il.com>
> >> ---
> >>  kernel/watchdog.c |    5 +++++
> >>  1 files changed, 5 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> >> index 75a2ab3..8a20ebe 100644
> >> --- a/kernel/watchdog.c
> >> +++ b/kernel/watchdog.c
> >> @@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write,
> >>               return ret;
> >>
> >>       set_sample_period();
> >> +     /*
> >> +      * Watchdog threads shouldn't be enabled if they are
> >> +      * disabled.'watchdog_disabled' variable check in
> >
> > Missing a 'The'  ^^^
> >
> > Other than that,
> >
> > Acked-by: Don Zickus <dzickus@...hat.com>
> Is this patch picked up?

Andrew,

Do you want me to respin the patch with that change? Or how should I move
this patch forward?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/