linux-kernel - Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130308131735.GJ26148@caracas.corpusers.net>
Date:	Fri, 8 Mar 2013 14:17:35 +0100
From:	<oskar.andero@...ymobile.com>
To:	Ananth N Mavinakayanahalli <ananth@...ibm.com>
CC:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"anil.s.keshavamurthy@...el.com" <anil.s.keshavamurthy@...el.com>,
	"Lekanovic, Radovan" <Radovan.Lekanovic@...ymobile.com>,
	"??? <bjorn.davidsson@...ymobile.com>@thinktux.in.ibm.com" 
	<� <bjorn.davidsson@...ymobile.com>@thinktux.in.ibm.com>
Subject: Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols

On 07:03 Fri 08 Mar     , Ananth N Mavinakayanahalli wrote:
> On Fri, Mar 08, 2013 at 01:23:25PM +0900, Masami Hiramatsu wrote:
> > (2013/03/07 19:44), oskar.andero@...ymobile.com wrote:
> > > From: Bjorn Davidsson <bjorn.davidsson@...ymobile.com>
> > > 
> > > The kprobes blacklist contains x86-specific symbols.
> > > Looking for these in kallsyms takes unnecessary time
> > > during startup on non-X86 platform.
> > > Added #ifdef CONFIG_X86 around them.
> > 
> > Right. however, it might be better break that into
> > common and arch-specific lists, because there may be
> > other arch-specific non-probe-able functions on each
> > architecture...
> 
> Agreed. CONFIG_<arch> in kernel/* is not the right thing to do IMO.
> 
> You are moving the blacklist initialization to later in the next patch,
> so how much overhead will it then be?

Well, it's not crucial for the boot time, but it is still a small
optimization.

-Oskar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/