[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <513A8F13.3070402@hitachi.com>
Date: Sat, 09 Mar 2013 10:23:31 +0900
From: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To: oskar.andero@...ymobile.com
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"anil.s.keshavamurthy@...el.com" <anil.s.keshavamurthy@...el.com>,
"ananth@...ibm.com" <ananth@...ibm.com>,
"Lekanovic, Radovan" <Radovan.Lekanovic@...ymobile.com>,
"Davidsson, Björn"
<Bjorn.Davidsson@...ymobile.com>
Subject: Re: Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific
symbols
(2013/03/08 22:15), oskar.andero@...ymobile.com wrote:
> On 05:23 Fri 08 Mar , Masami Hiramatsu wrote:
>> (2013/03/07 19:44), oskar.andero@...ymobile.com wrote:
>>> From: Bjorn Davidsson <bjorn.davidsson@...ymobile.com>
>>>
>>> The kprobes blacklist contains x86-specific symbols.
>>> Looking for these in kallsyms takes unnecessary time
>>> during startup on non-X86 platform.
>>> Added #ifdef CONFIG_X86 around them.
>>
>> Right. however, it might be better break that into
>> common and arch-specific lists, because there may be
>> other arch-specific non-probe-able functions on each
>> architecture...
>
> Ok. You mean adding, for instance, a kprobe_blacklist_arch[] in arch/x86
> somewhere or did you have something else in mind? I guess we preferably want
> to get rid of the #ifdef.
Yes, we can have symbol tables (const char *arch_kprobes_blacksyms[],
common_kprobes_blacksyms[]) to list it up, and when initializing
the blacklist table, we can check whether kprobes_blacklist == NULL
and initialize it.
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists