linux-kernel - Re: [PATCH] HID: holtek: Holtek devices depends on USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <513A4FA2.6070309@infradead.org>
Date:	Fri, 08 Mar 2013 12:52:50 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
CC:	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID

On 03/07/13 01:48, Benjamin Tissoires wrote:
> In the HID drivers tranport cleanup series, I removed the dependency
> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
> extensively on usb calls.
> 
> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>


but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:

ERROR: "usb_control_msg" [drivers/hid/hid-multitouch.ko] undefined!


> ---
>  drivers/hid/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 3abb11f..613083a 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -215,7 +215,7 @@ config HID_EZKEY
>  
>  config HID_HOLTEK
>  	tristate "Holtek HID devices"
> -	depends on HID
> +	depends on USB_HID
>  	---help---
>  	Support for Holtek based devices:
>  	  - Holtek On Line Grip based game controller
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/