linux-kernel - Re: [PATCH] HID: holtek: Holtek devices depends on USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Mar 2013 22:00:44 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID

On Fri, 8 Mar 2013, Randy Dunlap wrote:

> > In the HID drivers tranport cleanup series, I removed the dependency
> > between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
> > extensively on usb calls.
> > 
> > This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
> > 
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> 
> 
> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:

Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH, 
hence that shouldn't be a problem.

There used to be a problem in linux-next, but that should be fixed by 
4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have 
pushed out yesterday.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/