linux-kernel - Re: [PATCH] s390: replace kmalloc + memset with kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLGZ=6r85D5OBrFehbpjVSTvK-vaMGQGD9W0ssymT4QyTw@mail.gmail.com>
Date:	Sun, 10 Mar 2013 16:14:00 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Stelian Nirlu <steliannirlu@...il.com>
Cc:	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	linux390@...ibm.com, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: replace kmalloc + memset with kzalloc

On Sun, Mar 10, 2013 at 3:13 PM, Stelian Nirlu <steliannirlu@...il.com> wrote:
> Signed-off-by: Stelian Nirlu <steliannirlu@...il.com>
> ---
>  arch/s390/net/bpf_jit_comp.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> index 0972e91..e645528 100644
> --- a/arch/s390/net/bpf_jit_comp.c
> +++ b/arch/s390/net/bpf_jit_comp.c
> @@ -747,10 +747,9 @@ void bpf_jit_compile(struct sk_filter *fp)
>
>         if (!bpf_jit_enable)
>                 return;
> -       addrs = kmalloc(fp->len * sizeof(*addrs), GFP_KERNEL);
> +       addrs = kzalloc(fp->len * sizeof(*addrs), GFP_KERNEL);

kcalloc() might be more appropriate here to protect against integer
overflow if "fp->len" is too large.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/