linux-kernel - Re: [PATCH V2 2/5] rtc: tegra: Use struct dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130311085132.GA7900@avionic-0098.mockup.avionic-design.de>
Date:	Mon, 11 Mar 2013 09:51:33 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	akpm@...ux-foundation.org, a.zummo@...ertech.it,
	swarren@...dotorg.org, rtc-linux@...glegroups.com,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power
 management

On Mon, Mar 11, 2013 at 02:14:25PM +0530, Laxman Dewangan wrote:
[...]
> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
[...]
> @@ -431,6 +430,8 @@ static int tegra_rtc_resume(struct platform_device *pdev)
>  }
>  #endif
>  
> +SIMPLE_DEV_PM_OPS(tegra_rtc_pm_ops, tegra_rtc_suspend, tegra_rtc_resume);

I should've been more explicit. Since you had this marked as static in
the previous patch, this needs to be static SIMPLE_DEV_PM_OPS.

With that change,

Reviewed-by: Thierry Reding <thierry.reding@...onic-design.de>

Content of type "application/pgp-signature" skipped