linux-kernel - Re: [PATCH 2/4] drivers: android: binder: Fix code style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Mar 2013 00:54:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mirsal Ennaime <mirsal@...sal.fr>
Cc:	Greg Kroah-Hartman <greg@...ah.com>, devel@...verdev.osuosl.org,
	Brian Swetland <swetland@...gle.com>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	Arve Hjønnevåg <arve@...roid.com>
Subject: Re: [PATCH 2/4] drivers: android: binder: Fix code style

On Mon, Mar 11, 2013 at 08:31:53PM +0100, Mirsal Ennaime wrote:
> @@ -2943,28 +2944,39 @@ static void binder_deferred_release(struct binder_proc *proc)
>  
>  	threads = 0;
>  	active_transactions = 0;
> +

The blank line here isn't really appropriate.  The initialization is
logically a part of the loop.  It's part of the same paragraph.

>  	while ((n = rb_first(&proc->threads))) {
> -		struct binder_thread *thread = rb_entry(n, struct binder_thread, rb_node);
> +		struct binder_thread *thread = rb_entry(n,
> +			struct binder_thread,
> +			rb_node);

Do this instead:
		struct binder_thread *thread;

		thread = rb_entry(n, struct binder_thread, rb_node);

> +
>  		threads++;
>  		active_transactions += binder_free_thread(proc, thread);
>  	}
> +
>  	nodes = 0;
>  	incoming_refs = 0;
> +
>  	while ((n = rb_first(&proc->nodes))) {
> -		struct binder_node *node = rb_entry(n, struct binder_node, rb_node);
> +		struct binder_node *node = rb_entry(n,
> +			struct binder_node,
> +			rb_node);
>  

Same thing again.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/