linux-kernel - Re: [PATCH 5/8] memory: emif: use restart if power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <513D6E2D.4040805@ti.com>
Date:	Mon, 11 Mar 2013 11:09:57 +0530
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	Lokesh Vutla <lokeshvutla@...com>
CC:	<linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, Nishanth Menon <nm@...com>
Subject: Re: [PATCH 5/8] memory: emif: use restart if power_off not present
 when out of spec

On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote:
> From: Nishanth Menon <nm@...com>
> 
> Some machine or kernel variants might have missed implementation
> of power off handlers. We DONOT want to let the system be in
> "out of spec" state in this condition. So, WARN and attempt
> a machine restart in the hopes of clearing the out-of-spec
> temperature condition.
> 
> NOTE: This is not the safest option, but safer than leaving the
> system in unstable conditions.
> 
> Signed-off-by: Nishanth Menon <nm@...com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@...com>
> ---
>  drivers/memory/emif.c |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index 927fb55..02a94fc 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -25,6 +25,7 @@
>  #include <linux/module.h>
>  #include <linux/list.h>
>  #include <linux/spinlock.h>
> +#include <linux/pm.h>
>  #include <memory/jedec_ddr.h>
>  #include "emif.h"
>  #include "of_memory.h"
> @@ -1011,7 +1012,13 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
>  
>  	if (emif->temperature_level == SDRAM_TEMP_VERY_HIGH_SHUTDOWN) {
>  		dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
> -		kernel_power_off();
Extra line here would be good here.
> +		/* If we have Power OFF ability, use it, else try restarting */
> +		if (pm_power_off) {
> +			kernel_power_off();
> +		} else {
> +			WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
> +			kernel_restart("SDRAM Over-temp Emergency restart");
> +		}
>  		return IRQ_HANDLED;
>  	}
>  
Otherwise,
Acked-by: Santosh Shilimkar <santosh.shilimkar@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/