linux-kernel - Re: [PATCH 6/8] memory: emif: fix timings initialization issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Mar 2013 11:14:32 +0530
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	Lokesh Vutla <lokeshvutla@...com>
CC:	<linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Oleksandr Dmytryshyn <oleksandr.dmytryshyn@...com>
Subject: Re: [PATCH 6/8] memory: emif: fix timings initialization issue

$subject is too vague. What issue ?
Some thing like "Fix the incorrect 'size' parameter in memcpy' etc

On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote:
> From: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@...com>
> 
> The issue was that only the first timings table was added to the
> emif platform data at the emif driver registration. All other
> timings tables was filled with zeros. Now all emif timings table
> are added to the platform data.
>
Luckily, most of the cases, first table has been re-used for
symmetric configuration.
 
> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@...com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@...com>
> ---
>  drivers/memory/emif.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index 02a94fc..f75806a 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -1463,7 +1463,7 @@ static struct emif_data *__init_or_module get_device_details(
>  	if (pd->timings) {
>  		temp = devm_kzalloc(dev, size, GFP_KERNEL);
>  		if (temp) {
> -			memcpy(temp, pd->timings, sizeof(*pd->timings));
> +			memcpy(temp, pd->timings, size);
>  			pd->timings = temp;
>  		} else {
>  			dev_warn(dev, "%s:%d: allocation error\n", __func__,
> 
Patch as such looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/