linux-kernel - Re: [PATCH v3 4/7] KEYS: split call to call_usermodehelper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.02.1303121205090.25612@tundra.namei.org>
Date:	Tue, 12 Mar 2013 12:05:53 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
cc:	Oleg Nesterov <oleg@...hat.com>, lucas.de.marchi@...il.com,
	David Howells <dhowells@...hat.com>,
	James Morris <james.l.morris@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/7] KEYS: split call to call_usermodehelper_fns()

On Mon, 11 Mar 2013, Lucas De Marchi wrote:

> Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
> calling call_usermodehelper_fns(). In case there's an OOM in this last
> function the cleanup function may not be called - in this case we would
> miss a call to key_put().
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@...fusion.mobi>

Acked-by: James Morris <james.l.morris@...cle.com>




-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/