linux-kernel - RE: [PATCH v6 12/16] spi/spi-atmel: add pinctrl support for atmel spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A2436414972659B@penmbx02>
Date:	Tue, 12 Mar 2013 01:10:15 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"richard.genoud@...il.com" <richard.genoud@...il.com>,
	"Lin, JM" <JM.Lin@...el.com>,
	"spi-devel-general@...ts.sourceforge.net" 
	<spi-devel-general@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 12/16] spi/spi-atmel: add pinctrl support for atmel
 spi

Hi JC,

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@...osoft.com]
> Sent: 2013年3月11日 21:11
> To: Yang, Wenyou
> Cc: linux-arm-kernel@...ts.infradead.org; grant.likely@...retlab.ca; Ferre,
> Nicolas; richard.genoud@...il.com; Lin, JM;
> spi-devel-general@...ts.sourceforge.net; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v6 12/16] spi/spi-atmel: add pinctrl support for atmel spi
> 
> On 11:34 Thu 07 Mar     , Wenyou Yang wrote:
> > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> > Cc: spi-devel-general@...ts.sourceforge.net
> > Cc: linux-kernel@...r.kernel.org
> > ---
> >  drivers/spi/spi-atmel.c |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> > index 1e212d1..6b166f4 100644
> > --- a/drivers/spi/spi-atmel.c
> > +++ b/drivers/spi/spi-atmel.c
> > @@ -23,6 +23,7 @@
> >  #include <linux/platform_data/atmel.h>
> >  #include <linux/platform_data/dma-atmel.h>
> >  #include <linux/of.h>
> > +#include <linux/pinctrl/consumer.h>
> >
> >  #include <linux/io.h>
> >  #include <linux/gpio.h>
> > @@ -1493,11 +1494,18 @@ static int atmel_spi_probe(struct
> platform_device *pdev)
> >  	int			ret;
> >  	struct spi_master	*master;
> >  	struct atmel_spi	*as;
> > +	struct pinctrl		*pinctrl;
> >
> >  	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >  	if (!regs)
> >  		return -ENXIO;
> >
> > +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> > +	if (IS_ERR(pinctrl)) {
> > +		dev_err(&pdev->dev, "Failed to request pinctrl\n");
> > +		return PTR_ERR(pinctrl);
> > +	}
> 
> drop this, this is handled at bus level
> 
Thanks a lot for your advance.

> Best Regards,
> J.

Best Regards
Wenyou Yang
> > +
> >  	irq = platform_get_irq(pdev, 0);
> >  	if (irq < 0)
> >  		return irq;
> > --
> > 1.7.9.5
> >