linux-kernel - Re: [lm-sensors] [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130313045656.GA15989@roeck-us.net>
Date:	Tue, 12 Mar 2013 21:56:56 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
Cc:	devicetree-discuss@...ts.ozlabs.org, dianders@...omium.org,
	linux-kernel@...r.kernel.org, naveenkrishna.ch@...il.com,
	lm-sensors@...sensors.org
Subject: Re: [lm-sensors] [PATCH v4] hwmon: ntc: Add DT with IIO support to
 NTC thermistor driver

On Tue, Mar 12, 2013 at 09:52:26PM -0700, Guenter Roeck wrote:
> On Wed, Mar 13, 2013 at 09:38:20AM +0530, Naveen Krishna Chatradhi wrote:
> > This patch adds DT support to NTC driver to parse the
> > platform data.
> > 
> > Also adds the support to work as an iio device.
> > 
> > During the probe ntc driver gets the respective channels of ADC
> > and uses iio_raw_read calls to get the ADC converted value.
> > 
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
> 
> Unfortunately there is still something we'll need to sort out:
> 
> fs/sysfs/Kconfig:1:     symbol SYSFS is selected by AT91_ADC
> drivers/iio/adc/Kconfig:85:     symbol AT91_ADC depends on IIO
> drivers/iio/Kconfig:5:  symbol IIO is selected by SENSORS_NTC_THERMISTOR
> drivers/hwmon/Kconfig:900:      symbol SENSORS_NTC_THERMISTOR depends on HWMON
> drivers/hwmon/Kconfig:5:        symbol HWMON is selected by EEEPC_LAPTOP
> drivers/platform/x86/Kconfig:477:       symbol EEEPC_LAPTOP depends on
> HOTPLUG_PCI
> drivers/pci/hotplug/Kconfig:5:  symbol HOTPLUG_PCI depends on SYSFS
> 
> So we can not just select IIO. I'll see if I can find a solution.
> 
Here it is:

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index f7adbe8..47d2176 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -899,7 +899,7 @@ config SENSORS_MCP3021

 config SENSORS_NTC_THERMISTOR
         tristate "NTC thermistor support"
-	 select IIO if OF
+	 depends on (!OF && !IIO) || (OF && IIO)
	 help
		This driver supports NTC thermistors sensor reading and its
		interpretation. The driver can also monitor the temperature and

I'll modify the patch accordingly. No need to resubmit.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/