linux-kernel - Re: [PATCH] usb: limit OMAP related USB options to OMAP2PLUS platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5141EA01.3060905@windriver.com>
Date:	Thu, 14 Mar 2013 11:17:21 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	<balbi@...com>
CC:	<linux-usb@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] usb: limit OMAP related USB options to OMAP2PLUS platforms

On 13-02-27 02:57 PM, Paul Gortmaker wrote:
> On 13-02-27 02:51 PM, Felipe Balbi wrote:
>> HI,
>>
>> On Wed, Feb 27, 2013 at 02:08:39PM -0500, Paul Gortmaker wrote:
>>> commit 57f6ce072e35770a63be0c5d5e82f90d8da7d665 ("usb: phy:
>>> add a new driver for usb3 phy") added the new Kconfig option
>>> OMAP_USB3, but it had no dependencies whatsoever, and hence
>>> became available across all arch/platforms.
>>>
>>> Which presumably caused this to show up in x86 randconfig:
>>>
>>>     warning: (USB_MUSB_HDRC && OMAP_USB3) selects \
>>>         OMAP_CONTROL_USB which has unmet direct \
>>>         dependencies (USB_SUPPORT && ARCH_OMAP2PLUS)
>>>
>>> Then commit 6992819feb39cb9adac72170555d957d07f869f2 ("usb: phy:
>>> fix Kconfig warning") was added.  However, this just deleted the
>>> ARCH_OMAP2PLUS dependency from OMAP_CONTROL_USB, further
>>> compounding the problem by opening up OMAP_CONTROL_USB to
>>> all arch/platforms as well.
>>>
>>> Here we revert the change of 6992819feb to restore the dependency,
>>> and add the same ARCH_OMAP2PLUS dependency to the new OMAP_USB3.
>>>
>>> Perhaps a more platform specific dependency could be chosen for
>>> OMAP_USB3, but at least this keeps it from bleeding out to other
>>> architectures and non-OMAP ARM platforms as it is currently doing.
>>>
>>> Cc: Felipe Balbi <balbi@...com>
>>> Cc: Kishon Vijay Abraham I <kishon@...com>
>>> Cc: Moiz Sonasath <m-sonasath@...com>
>>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
>>> ---
>>>  drivers/usb/phy/Kconfig | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
>>> index 65217a5..40b8463 100644
>>> --- a/drivers/usb/phy/Kconfig
>>> +++ b/drivers/usb/phy/Kconfig
>>> @@ -17,6 +17,7 @@ config OMAP_USB2
>>>  
>>>  config OMAP_USB3
>>>  	tristate "OMAP USB3 PHY Driver"
>>> +	depends on ARCH_OMAP2PLUS
>>>  	select USB_OTG_UTILS
>>>  	select OMAP_CONTROL_USB
>>>  	help
>>> @@ -27,6 +28,7 @@ config OMAP_USB3
>>>  
>>>  config OMAP_CONTROL_USB
>>>  	tristate "OMAP CONTROL USB Driver"
>>> +	depends on ARCH_OMAP2PLUS
>>
>> I rather not add dependencies here and fix the selections of
>> OMAP_CONTROL_USB.
> 
> I am not sure I understand what you mean, or why you wouldn't
> want sane dependencies in place like those given above.  Perhaps
> you can send an alternate patch so there is no ambiguity?

Hi Felipe,

I'm still seeing the OMAP settings in x86 builds on mainline
from today, and since I'd not got a reply to the above, I'm
still wondering what alternative you have in mind vs. my
above patch.  We can't be having the arch specific settings
leaking out to the other arch where they make no sense[1].

Thanks,
Paul.

[1] https://lkml.org/lkml/2013/3/7/456
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/