linux-kernel - Re: [PATCH] usb: limit OMAP related USB options to OMAP2PLUS platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130314161204.GE3001@arwen.pp.htv.fi>
Date:	Thu, 14 Mar 2013 18:12:04 +0200
From:	Felipe Balbi <balbi@...com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	<balbi@...com>, <linux-usb@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] usb: limit OMAP related USB options to OMAP2PLUS
 platforms

Hi,

On Thu, Mar 14, 2013 at 11:17:21AM -0400, Paul Gortmaker wrote:
> >>> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> >>> index 65217a5..40b8463 100644
> >>> --- a/drivers/usb/phy/Kconfig
> >>> +++ b/drivers/usb/phy/Kconfig
> >>> @@ -17,6 +17,7 @@ config OMAP_USB2
> >>>  
> >>>  config OMAP_USB3
> >>>  	tristate "OMAP USB3 PHY Driver"
> >>> +	depends on ARCH_OMAP2PLUS
> >>>  	select USB_OTG_UTILS
> >>>  	select OMAP_CONTROL_USB
> >>>  	help
> >>> @@ -27,6 +28,7 @@ config OMAP_USB3
> >>>  
> >>>  config OMAP_CONTROL_USB
> >>>  	tristate "OMAP CONTROL USB Driver"
> >>> +	depends on ARCH_OMAP2PLUS
> >>
> >> I rather not add dependencies here and fix the selections of
> >> OMAP_CONTROL_USB.
> > 
> > I am not sure I understand what you mean, or why you wouldn't
> > want sane dependencies in place like those given above.  Perhaps
> > you can send an alternate patch so there is no ambiguity?
> 
> Hi Felipe,
> 
> I'm still seeing the OMAP settings in x86 builds on mainline
> from today, and since I'd not got a reply to the above, I'm
> still wondering what alternative you have in mind vs. my
> above patch.  We can't be having the arch specific settings
> leaking out to the other arch where they make no sense[1].

why not ? It forces people to write portable drivers, it forces people
to avoid including the wrong headers and allows maintainers and patch
authors to easily compile test their drivers.

On top of all that, it lets me better use linux-next as a big build
testing before I send a pull request to Greg.

When you're going to build a product, you will come up with a proper
.config anyway. Because of a bunch of these misused 'depends on' and
'select' statements that right now ARM multiplatform builds don't even
compile cleanly if you enable all ARM-related drivers.

Until all of those are cleaned up, the best way is to force people to
write drivers which compile in all architectures and make sure Kconfig
doesn't add any ARCH dependency.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)