linux-kernel - Re: [PATCH 2/2] task_work: check callback if it's NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <514272D3.7040901@huawei.com>
Date:	Fri, 15 Mar 2013 09:01:07 +0800
From:	Li Zefan <lizefan@...wei.com>
To:	li guang <lig.fnst@...fujitsu.com>
CC:	Oleg Nesterov <oleg@...hat.com>, <viro@...iv.linux.org.uk>,
	<edumazet@...gle.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] task_work: check callback if it's NULL

On 2013/3/15 8:20, li guang wrote:
> 在 2013-03-14四的 15:43 +0100，Oleg Nesterov写道：
>> On 03/14, liguang wrote:
>>>
>>> Signed-off-by: liguang <lig.fnst@...fujitsu.com>
>>> ---
>>>  kernel/task_work.c |    3 ++-
>>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/kernel/task_work.c b/kernel/task_work.c
>>> index 0bf4258..f458b08 100644
>>> --- a/kernel/task_work.c
>>> +++ b/kernel/task_work.c
>>> @@ -75,7 +75,8 @@ void task_work_run(void)
>>>
>>>  		do {
>>>  			next = work->next;
>>> -			work->func(work);
>>> +			if (unlikely(work->func))
>>> +				work->func(work);
>>
>> Why?
>>
>> Oleg.
>>
> 
> can we believe a callback always be call-able?
> can it happened to be 0? e.g. wrong initialized.
> of course, we can complain the caller, be why don't
> we easily make it more safer?
> 

Because you're not making things safer, but your're trying
to cover up bugs...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/