linux-kernel - Re: [PATCH 2/5] pinctrl: ab8500: Staticize some symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <514824C1.8040306@st.com>
Date:	Tue, 19 Mar 2013 09:41:37 +0100
From:	Patrice CHOTARD <patrice.chotard@...com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"patches@...aro.org" <patches@...aro.org>
Subject: Re: [PATCH 2/5] pinctrl: ab8500: Staticize some symbols

On 03/19/2013 07:31 AM, Sachin Kamat wrote:

> These symbols are used only in this file. Silences the following
> warnings:
> drivers/pinctrl/pinctrl-ab8500.c:392:28: warning:
> symbol 'ab8500_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8500.c:458:32: warning:
> symbol 'ab8500_gpio_irq_cluster' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> Cc: Patrice Chotard <patrice.chotard@...ricsson.com>
> ---
>  drivers/pinctrl/pinctrl-ab8500.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ab8500.c b/drivers/pinctrl/pinctrl-ab8500.c
> index 3b471d8..2ac2d0a 100644
> --- a/drivers/pinctrl/pinctrl-ab8500.c
> +++ b/drivers/pinctrl/pinctrl-ab8500.c
> @@ -389,7 +389,8 @@ static const struct abx500_function ab8500_functions[] = {
>   *	alt_A	|       1       |          0          |          0
>   */
>  
> -struct alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1] = {
>  	ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
>  	ALTERNATE_FUNCTIONS(1,	    0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
>  	ALTERNATE_FUNCTIONS(2,      1, UNUSED, UNUSED, 0, 0, 0), /* GPIO2, altA controlled by bit 1 */
> @@ -455,7 +456,7 @@ struct alternate_functions ab8500_alternate_functions[AB8500_GPIO_MAX_NUMBER + 1
>   *	GPIO24 and GPIO25
>   *	GPIO36 to GPIO41
>   */
> -struct abx500_gpio_irq_cluster ab8500_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab8500_gpio_irq_cluster[] = {
>  	GPIO_IRQ_CLUSTER(6,  13, AB8500_INT_GPIO6R),
>  	GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R),
>  	GPIO_IRQ_CLUSTER(36, 41, AB8500_INT_GPIO36R),


Acked-by: Patrice Chotard <patrice.chotard@...com>--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/