linux-kernel - Re: [PATCH 3/5] pinctrl: ab9540: Staticize some symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Mar 2013 09:42:58 +0100
From:	Patrice CHOTARD <patrice.chotard@...com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"patches@...aro.org" <patches@...aro.org>
Subject: Re: [PATCH 3/5] pinctrl: ab9540: Staticize some symbols

On 03/19/2013 07:31 AM, Sachin Kamat wrote:

> Fixes the following warnings:
> drivers/pinctrl/pinctrl-ab9540.c:382:28: warning:
> symbol 'ab9540alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab9540.c:457:32: warning:
> symbol 'ab9540_gpio_irq_cluster' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> Cc: Patrice Chotard <patrice.chotard@...ricsson.com>
> ---
>  drivers/pinctrl/pinctrl-ab9540.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ab9540.c b/drivers/pinctrl/pinctrl-ab9540.c
> index 7610bd0..27835ce 100644
> --- a/drivers/pinctrl/pinctrl-ab9540.c
> +++ b/drivers/pinctrl/pinctrl-ab9540.c
> @@ -379,7 +379,8 @@ static const struct abx500_function ab9540_functions[] = {
>   *	alt_A	|       1       |          0          |          0
>   */
>  
> -struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1] = {
>  	/* GPIOSEL1 - bits 4-7 are reserved */
>  	ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
>  	ALTERNATE_FUNCTIONS(1,	    0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
> @@ -454,7 +455,7 @@ struct alternate_functions ab9540alternate_functions[AB9540_GPIO_MAX_NUMBER + 1]
>  	ALTERNATE_FUNCTIONS(54,	     5, UNUSED, UNUSED, 0, 0, 0), /* GPIO54 = GPIO60, altA controlled by bit 5 */
>  };
>  
> -struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab9540_gpio_irq_cluster[] = {
>  	GPIO_IRQ_CLUSTER(10, 13, AB8500_INT_GPIO10R),
>  	GPIO_IRQ_CLUSTER(24, 25, AB8500_INT_GPIO24R),
>  	GPIO_IRQ_CLUSTER(40, 41, AB8500_INT_GPIO40R),


Fyi, don't use my stericsson email address as it has been disabled.

Acked-by: Patrice Chotard <patrice.chotard@...com>--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/