linux-kernel - Re: [PATCH 4/5] pinctrl: ab8540: Staticize some symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Mar 2013 09:43:09 +0100
From:	Patrice CHOTARD <patrice.chotard@...com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"patches@...aro.org" <patches@...aro.org>
Subject: Re: [PATCH 4/5] pinctrl: ab8540: Staticize some symbols

On 03/19/2013 07:31 AM, Sachin Kamat wrote:

> Silences the following warnings:
> drivers/pinctrl/pinctrl-ab8540.c:302:28: warning:
> symbol 'ab8540_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8540.c:379:32: warning:
> symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> Cc: Patrice Chotard <patrice.chotard@...ricsson.com>
> ---
>  drivers/pinctrl/pinctrl-ab8540.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c
> index 8ee1e8d..9867535 100644
> --- a/drivers/pinctrl/pinctrl-ab8540.c
> +++ b/drivers/pinctrl/pinctrl-ab8540.c
> @@ -299,7 +299,8 @@ static const struct abx500_function ab8540_functions[] = {
>   *
>   */
>  
> -struct alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
>  	/* GPIOSEL1 - bit 4-7 reserved */
>  	ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
>  	ALTERNATE_FUNCTIONS(1,	    0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
> @@ -376,7 +377,7 @@ static struct pullud ab8540_pullud = {
>   *	GPIO43 to GPIO44
>   *	GPIO51 to GPIO54
>   */
> -struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
>  	GPIO_IRQ_CLUSTER(43, 43, AB8540_INT_GPIO43F),
>  	GPIO_IRQ_CLUSTER(44, 44, AB8540_INT_GPIO44F),
>  	GPIO_IRQ_CLUSTER(51, 54, AB9540_INT_GPIO51R),



Acked-by: Patrice Chotard <patrice.chotard@...com>--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/