linux-kernel - Re: [PATCH v2] davinci: vpif: Fix module build for capture and display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130319153043.23f7d127@redhat.com>
Date:	Tue, 19 Mar 2013 15:30:43 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Prabhakar lad <prabhakar.csengg@...il.com>
Cc:	LMML <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	Sekhar Nori <nsekhar@...com>
Subject: Re: [PATCH v2] davinci: vpif: Fix module build for capture and
 display

Em Fri,  8 Mar 2013 16:19:07 +0530
Prabhakar lad <prabhakar.csengg@...il.com> escreveu:

> From: Lad, Prabhakar <prabhakar.csengg@...il.com>
> 
> export the symbols which are used by two modules vpif_capture and
> vpif_display.
> 
> This patch fixes following error:
> ERROR: "ch_params" [drivers/media/platform/davinci/vpif_display.ko] undefined!
> ERROR: "vpif_ch_params_count" [drivers/media/platform/davinci/vpif_display.ko] undefined!
> ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_display.ko] undefined!
> ERROR: "ch_params" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
> ERROR: "vpif_ch_params_count" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
> ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
> make[1]: *** [__modpost] Error 1
> 
> Reported-by: Sekhar Nori <nsekhar@...com>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> ---
>  Changes for v2:
>  1: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL() as pointed by
>     Sekhar.
> 
>  drivers/media/platform/davinci/vpif.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> index 28638a8..42c7eba 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -44,6 +44,8 @@ static struct resource	*res;
>  spinlock_t vpif_lock;
>  
>  void __iomem *vpif_base;
> +EXPORT_SYMBOL_GPL(vpif_base);
> +
>  struct clk *vpif_clk;
>  
>  /**
> @@ -220,8 +222,10 @@ const struct vpif_channel_config_params ch_params[] = {
>  		.stdid = V4L2_STD_625_50,
>  	},
>  };
> +EXPORT_SYMBOL_GPL(ch_params);

Please don't use simple names like that. It would be very easy that some
other driver could try to declare the same symbol. Instead, prefix it
with the driver name (vpif_ch_params).

>  
>  const unsigned int vpif_ch_params_count = ARRAY_SIZE(ch_params);
> +EXPORT_SYMBOL_GPL(vpif_ch_params_count);
>  
>  static inline void vpif_wr_bit(u32 reg, u32 bit, u32 val)
>  {

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/