linux-kernel - Re: [PATCH 1/2] dma-debug: Fix locking bug in check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363724947.4519.9.camel@lorien2>
Date:	Tue, 19 Mar 2013 14:29:07 -0600
From:	Shuah Khan <shuah.khan@...com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	linux-kernel@...r.kernel.org, konrad.wilk@...cle.com,
	joerg.roedel@....com, konrad@...nel.org,
	christoph.paasch@...ouvain.be, mingo@...hat.com, hpa@...or.com,
	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com, shuah.khan@...com
Subject: Re: [PATCH 1/2] dma-debug: Fix locking bug in check_unmap

On Mon, 2013-03-18 at 15:12 -0700, Alexander Duyck wrote:
> In check_unmap it is possible to get into a dead-locked state if
> dma_mapping_error is called.  The problem is that the bucket is locked in
> check_unmap, and locked again by debug_dma_mapping_error which is called by
> dma_mapping_error.  To resolve that we must release the lock on the bucket
> before making the call to dma_mapping_error.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>

Looks good.

Reviewed-by: Shuah Khan
Tested-by Shuah Khan

Thanks for finding and fixing the problem.
-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/