linux-kernel - Re: [RFC PATCHv2 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130320125125.GP29659@arwen.pp.htv.fi>
Date:	Wed, 20 Mar 2013 14:51:25 +0200
From:	Felipe Balbi <balbi@...com>
To:	Michal Nazarewicz <mina86@...a86.com>
CC:	<oskar.andero@...ymobile.com>, <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...com>,
	<Radovan.Lekanovic@...ymobile.com>,
	Truls Bengtsson <truls.bengtsson@...ymobile.com>
Subject: Re: [RFC PATCHv2 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev
 can be null

On Tue, Mar 19, 2013 at 02:22:56PM +0100, Michal Nazarewicz wrote:
> On Tue, Mar 19 2013, oskar.andero@...ymobile.com wrote:
> > The udc_irq service runs the isr_tr_complete_handler which in turn
> > "nukes" the endpoints, including a call to rndis_response_complete,
> > if appropriate. If the rndis_msg_parser fails here, an error will
> > be printed using a dev_err call (through the ERROR() macro).
> >
> > However, if the usb cable was just disconnected the device (cdev)
> > might not be available and will be null. Since the dev_err macro will
> > dereference the cdev pointer we get a null pointer exception.
> >
> > Reviewed-by: Radovan Lekanovic <radovan.lekanovic@...ymobile.com>
> > Signed-off-by: Truls Bengtsson <truls.bengtsson@...ymobile.com>
> > Signed-off-by: Oskar Andero <oskar.andero@...ymobile.com>
> 
> Acked-by: Michal Nazarewicz <mina86@...a86.com>
> 
> I think this is the best solution.  Adding if statements around it would
> just add noise.

alright, please re-send without RFC tag and with Michal's acked-by so I
can apply.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)