linux-kernel - Re: [PATCH v7 1/9] mfd: Add commands abstraction layer for SI476X MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHQ1cqHviVN1cwTYvG7AuF4Fqj86LWvwxnGKT0hUVfearoOwCw@mail.gmail.com>
Date:	Tue, 19 Mar 2013 18:10:32 -0700
From:	Andrey Smirnov <andrew.smirnov@...il.com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Hans Verkuil <hverkuil@...all.nl>, sameo@...ux.intel.com,
	sam@...nborg.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/9] mfd: Add commands abstraction layer for SI476X MFD

On Mon, Mar 18, 2013 at 1:11 PM, Mauro Carvalho Chehab
<mchehab@...hat.com> wrote:
> Em Tue, 26 Feb 2013 22:06:45 -0800
> Andrey Smirnov <andrew.smirnov@...il.com> escreveu:
>
>> This patch adds all the functions used for exchanging commands with
>> the chip.
>
> Please run checkpatch.pl over those patches. There are a number of compliants
> on those patches:
>

OK, will do shortly and send updated patch-set.

> WARNING: line over 80 characters
> #328: FILE: drivers/mfd/si476x-cmd.c:298:
> +       err = si476x_core_i2c_xfer(core, SI476X_I2C_SEND, (char *) data, argn + 1);
>
> WARNING: line over 80 characters
> #378: FILE: drivers/mfd/si476x-cmd.c:348:
> +               dev_err(&core->client->dev, "[CMD 0x%02x] Chip set error flag\n", command);
>

I do have a question about this particular warning though. Weird
indentation that I had to use in order to calm checkpatch.pl about
that issue has been a topic of discussion and complaints once
already(see https://lkml.org/lkml/2012/9/21/67) To my understanding
the consensus was as far as it improves readability > 80 character
lines are OK. What would you like me do with those extra long lines
ignore all/fix all/use discretion and fix some?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/