linux-kernel - Re: linux-next: build failure after merge of the final tree (gpio tree relatred)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Mar 2013 02:25:24 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-next <linux-next@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ian Lartey <ian@...mlogic.co.uk>,
	Graeme Gregory <gg@...mlogic.co.uk>
Subject: Re: linux-next: build failure after merge of the final tree (gpio
 tree relatred)

Hi Grant,

On Wed, 6 Mar 2013 09:10:42 +0800 Grant Likely <grant.likely@...retlab.ca> wrote:
>
> On Wed, Mar 6, 2013 at 8:44 AM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/gpio/gpio-palmas.c: In function 'palmas_gpio_probe':
> > drivers/gpio/gpio-palmas.c:173:2: error: implicit declaration of function 'is_palmas_charger' [-Werror=implicit-function-declaration]
> > drivers/gpio/gpio-palmas.c:173:30: error: 'struct palmas' has no member named 'product_id'
> >
> > Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
> > palmas charger").  I wonder if this was ever build tested. :-(
> 
> Probably not. Looks like this driver doesn't get enabled without the
> associated option in MFD. I didn't go searching for it, so my build
> tests didn't catch it. I'll drop the patch from my tree. Sorry for the
> pain.

I am still having to revert this commit ....  :-(
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped