linux-kernel - Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130320014657.GA14714@google.com>
Date:	Tue, 19 Mar 2013 18:46:57 -0700
From:	Venkatesh Srinivas <venkateshs@...gle.com>
To:	Wanlong Gao <gaowanlong@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	linux-scsi@...r.kernel.org, mst@...hat.com,
	JBottomley@...allels.com,
	virtualization@...ts.linux-foundation.org, pbonzini@...hat.com,
	vsrinivas@...101.org, digitaleric@...gle.com, mikew@...gle.com
Subject: Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support

This looks pretty good!

I rather like the (lack of) locking in I/O completion (around the req
count vs. target/queue binding). It is unfortunate that you need to 
hold the per-target lock in virtscsi_pick_vq() though; have any idea
how much that lock hurts?

Just two minor comments:

(in struct virtio_scsi_target_data):
+       /* This spinlock never help at the same time as vq_lock. */
                                ^^^^ held?

(in struct virtio_scsi):
+       /* Does the affinity hint is set for virtqueues? */
Could you rephrase that, please?

Tested on qemu and w/ Google Compute Engine's virtio-scsi device.

Reviewed-and-tested-by: Venkatesh Srinivas <venkateshs@...gle.com>

Thanks,
-- vs;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/