linux-kernel - Re: linux-next: Tree for Mar 20 (vmcore)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1303201153330.17761@chino.kir.corp.google.com>
Date:	Wed, 20 Mar 2013 11:56:01 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Randy Dunlap <rdunlap@...radead.org>,
	HATAYAMA Daisuke <d.hatayama@...fujitsu.com>
cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	kexec@...ts.infradead.org
Subject: Re: linux-next: Tree for Mar 20 (vmcore)

On Wed, 20 Mar 2013, Randy Dunlap wrote:

> on x86_64:
> 
> fs/proc/vmcore.c: In function 'merge_note_headers_elf64':
> fs/proc/vmcore.c:349:22: error: 'VMCOREINFO_NOTE_NAME' undeclared (first use in this function)
> fs/proc/vmcore.c:349:22: note: each undeclared identifier is reported only once for each function it appears in
> fs/proc/vmcore.c: In function 'merge_note_headers_elf32':
> fs/proc/vmcore.c:470:22: error: 'VMCOREINFO_NOTE_NAME' undeclared (first use in this function)
> make[3]: *** [fs/proc/vmcore.o] Error 1
> 
> 
> Needs to #include <linux/kexec.h>
> 

I don't think that's it, linux/kexec.h already gets included indirectly.  
The problem is that CONFIG_KEXEC isn't set so the definition in kexec.h is 
meaningless.

This comes from "vmcore: check NT_VMCORE_PAD as a mark indicating the end 
of ELF note buffer" merged through the -mm tree.  I've added the patch's 
author and Andrew to the cc.

How can this be protected by CONFIG_KEXEC?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/