linux-kernel - Re: [ 12/48] signal: always clear sa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363830108.31336.83.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 21 Mar 2013 01:41:48 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	"Sebastian Gottschall (DD-WRT)" <s.gottschall@...wrt.com>
Cc:	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [ 12/48] signal: always clear sa_restorer on execve

On Wed, 2013-03-20 at 21:43 +0100, Sebastian Gottschall (DD-WRT) wrote:
> Am 20.03.2013 20:02, schrieb Sebastian Gottschall (DD-WRT):
> > Hello
> >
> > The patch for sa_restorer will break mips builds, since sa_restorer 
> > isnt defined as field within the struct, but the MACRO is.
> > so use the __ARCH_HAS_SA_RESTORER way which is implemented in that way 
> > in linux 3.9 or simply revert the patch

This also appears to break blackfin, ia64, parisc and tile.

I think for earlier 3.x.y series we can use one of the attached
(untested) patches to define __ARCH_HAS_SA_RESTORER appropriately, and
then apply the upstream change:

commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
Author: Andrew Morton <akpm@...ux-foundation.org>
Date:   Wed Mar 13 14:59:34 2013 -0700

    kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER

Ben.

-- 
Ben Hutchings
It is easier to write an incorrect program than to understand a correct one.

View attachment "signal-fix-use-of-missing-sa_restorer-field-3.0-3.2-3.4.patch" of type "text/x-patch" (4436 bytes)

View attachment "signal-fix-use-of-missing-sa_restorer-field-3.8.patch" of type "text/x-patch" (4380 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)