linux-kernel - signal: Define __ARCH_HAS_SA_RESTORER so we know whether to clear sa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1364273142.3520.16.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 26 Mar 2013 04:45:42 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	stable@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Sebastian Gottschall (DD-WRT)" <s.gottschall@...wrt.com>
Subject: signal: Define __ARCH_HAS_SA_RESTORER so we know whether to clear
 sa_restorer

On Thu, 2013-03-21 at 01:41 +0000, Ben Hutchings wrote:
> On Wed, 2013-03-20 at 21:43 +0100, Sebastian Gottschall (DD-WRT) wrote:
> > Am 20.03.2013 20:02, schrieb Sebastian Gottschall (DD-WRT):
> > > Hello
> > >
> > > The patch for sa_restorer will break mips builds, since sa_restorer 
> > > isnt defined as field within the struct, but the MACRO is.
> > > so use the __ARCH_HAS_SA_RESTORER way which is implemented in that way 
> > > in linux 3.9 or simply revert the patch
> 
> This also appears to break blackfin, ia64, parisc and tile.
> 
> I think for earlier 3.x.y series we can use one of the attached
> (untested) patches to define __ARCH_HAS_SA_RESTORER appropriately, and
> then apply the upstream change:
> 
> commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> Author: Andrew Morton <akpm@...ux-foundation.org>
> Date:   Wed Mar 13 14:59:34 2013 -0700
> 
>     kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
> 
> Ben.

The Debian package of 3.2.41, which included these two patches, built on
mips and ia64.  (Actually it failed on ia64, but *compilation* was
successful.)

(This does not, of course, prove that I didn't un-fix the information
leak.)

Here is the first patch again (separate versions for 3.8.y and for
earlier series), now with a more accurate subject line.  I'm going to
include this in 3.2.42.

Ben.

-- 
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.


Content of type "text/x-patch" skipped

Content of type "text/x-patch" skipped

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)