[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130321144218.GF9046@casper.infradead.org>
Date: Thu, 21 Mar 2013 14:42:18 +0000
From: Thomas Graf <tgraf@...g.ch>
To: Andrey Vagin <avagin@...nvz.org>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Pavel Emelyanov <xemul@...allels.com>,
Eric Dumazet <edumazet@...gle.com>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] net: fix *_DIAG_MAX constants
On 03/21/13 at 06:18pm, Andrey Vagin wrote:
> Follow the common pattern and define *_DIAG_MAX like:
>
> [...]
> __XXX_DIAG_MAX,
> };
>
> Because everyone is used to do:
>
> struct nlattr *attrs[XXX_DIAG_MAX+1];
>
> nla_parse([...], XXX_DIAG_MAX, [...]
>
> Reported-by: Thomas Graf <tgraf@...g.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Pavel Emelyanov <xemul@...allels.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> Cc: David Howells <dhowells@...hat.com>
> Signed-off-by: Andrey Vagin <avagin@...nvz.org>
Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists