linux-kernel - Re: [PATCH] net: fix *_DIAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130321.111437.2012746070698745131.davem@davemloft.net>
Date:	Thu, 21 Mar 2013 11:14:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	avagin@...nvz.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, xemul@...allels.com, edumazet@...gle.com,
	paulmck@...ux.vnet.ibm.com, dhowells@...hat.com
Subject: Re: [PATCH] net: fix *_DIAG_MAX constants

From: Thomas Graf <tgraf@...g.ch>
Date: Thu, 21 Mar 2013 14:42:18 +0000

> On 03/21/13 at 06:18pm, Andrey Vagin wrote:
>> Follow the common pattern and define *_DIAG_MAX like:
>> 
>>         [...]
>>         __XXX_DIAG_MAX,
>> };
>> 
>> Because everyone is used to do:
>> 
>>         struct nlattr *attrs[XXX_DIAG_MAX+1];
>> 
>>         nla_parse([...], XXX_DIAG_MAX, [...]
>> 
>> Reported-by: Thomas Graf <tgraf@...g.ch>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Pavel Emelyanov <xemul@...allels.com>
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
>> Cc: David Howells <dhowells@...hat.com>
>> Signed-off-by: Andrey Vagin <avagin@...nvz.org>
> 
> Acked-by: Thomas Graf <tgraf@...g.ch>

So you're ACK'ing a patch that makes changes to files that don't even
exist in the repository?

Andrey, post a clean patch against 'net' that fixes these constants
for existing code, don't just assume that your original patch set is
applied and post changes relative to that.  That's not how we work.

After the bug fix for the existing cases goes in, you have to repost
your original patch set on top of that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/