linux-kernel - Re: [patch] sound/soc/codec : fix build failure in next-201303225

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130325120601.GN18316@opensource.wolfsonmicro.com>
Date:	Mon, 25 Mar 2013 12:06:01 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Xiong Zhou <jencce.kernel@...il.com>
Cc:	linux-next@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] sound/soc/codec : fix build failure in next-201303225

On Mon, Mar 25, 2013 at 07:59:43PM +0800, Xiong Zhou wrote:

> -const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE] = {
> -	"SYNCCLK rate", "8kHz", "16kHz", "ASYNCCLK rate",
> -};
> +extern const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE];
>  EXPORT_SYMBOL_GPL(arizona_rate_text);

No, this isn't a good fix at all - we're moving the array to the header
but still exporting it from this file which is not clever at all.  The
user should be conditional.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)