linux-kernel - Re: [patch] sound/soc/codec : fix build failure in next-201303225

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1303252017020.20514@M2420>
Date:	Mon, 25 Mar 2013 20:34:27 +0800 (CST)
From:	Xiong Zhou <jencce.kernel@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
cc:	Xiong Zhou <jencce.kernel@...il.com>, linux-next@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] sound/soc/codec : fix build failure in next-201303225



On Mon, 25 Mar 2013, Mark Brown wrote:

> On Mon, Mar 25, 2013 at 07:59:43PM +0800, Xiong Zhou wrote:
> 
> > -const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE] = {
> > -	"SYNCCLK rate", "8kHz", "16kHz", "ASYNCCLK rate",
> > -};
> > +extern const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE];
> >  EXPORT_SYMBOL_GPL(arizona_rate_text);
> 
> No, this isn't a good fix at all - we're moving the array to the header
> but still exporting it from this file which is not clever at all.  The
> user should be conditional.
> 

Yes, I agree with you much. Do you have some plan with this array? 
The exproting seems not necesary right now, How about just moving 
the array to the header?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/