| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201303251247.58823.arnd@arndb.de> Date: Mon, 25 Mar 2013 12:47:58 +0000 From: Arnd Bergmann <arnd@...db.de> To: Heikki Krogerus <heikki.krogerus@...ux.intel.com> Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Ley Foon Tan <lftan@...era.com>, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org Subject: Re: [PATCH 3/3] serial: of_serial: Handle hw-flow-control property On Monday 25 March 2013, Heikki Krogerus wrote: > On Mon, Mar 25, 2013 at 11:40:31AM +0000, Arnd Bergmann wrote: > > On Monday 25 March 2013, Heikki Krogerus wrote: > > > This will add support for hardware flow control. It is > > > limited to be used only with 8250 driver. > > > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com> > > > > Does this imply that we can use hardware flow control only when this > > flag is set in the device tree? I assumed that working flow control > > would be the default. Is it not? > > OK, the commit message is wrong. Is the patch otherwise OK? I still find the text in the binding and the name of the property confusing, because it seems to imply that you have no hardware flow control without this. I think what you mean here is really "automatic flow control" rather than "hardware flow control". Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists