linux-kernel - Re: [PATCH v2 4/7] KEYS: split call to call_usermodehelper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Mar 2013 12:55:19 +0000
From:	David Howells <dhowells@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	dhowells@...hat.com,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	lucas.de.marchi@...il.com,
	James Morris <james.l.morris@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/7] KEYS: split call to call_usermodehelper_fns()

Oleg Nesterov <oleg@...hat.com> wrote:

> Looks correct, but can't we simpluify it a bit?
> 
> 	info = call_usermodehelper_setup(session_keyring);
> 	if (!info)
> 		return ENOMEM;

-ENOMEM;-)

> 	key_get(session_keyring));
> 	return call_usermodehelper_exec(info);

Looks reasonable.  I like it better this way as it makes working out how to
deal with all the error cases so much simpler:-).

Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/