linux-kernel - Re: [RFC] fsfreeze: moving from uniterruptible to killable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130326211520.GF2082@quack.suse.cz>
Date:	Tue, 26 Mar 2013 22:15:20 +0100
From:	Jan Kara <jack@...e.cz>
To:	Marco Stornelli <marco.stornelli@...il.com>
Cc:	Linux FS Devel <linux-fsdevel@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jan Kara <jack@...e.cz>
Subject: Re: [RFC] fsfreeze: moving from uniterruptible to killable

On Sun 24-03-13 10:10:59, Marco Stornelli wrote:
> When a fs is frozen, a process can hang because we wait in
> uniterruptible state. We give the user the possibility to kill the process.
  Yes, but it needs slightly more work as you probably know... (bailing out
properly when the signal arrives).

								Honza

> 
> Not-signed-off-by: Marco Stornelli <marco.stornelli@...il.com>
> ---
> 
> --- fs/super.c.orig	2013-03-24 09:56:33.000000000 +0100
> +++ fs/super.c	2013-03-24 09:58:41.000000000 +0100
> @@ -1198,7 +1198,7 @@ retry:
>  	if (unlikely(sb->s_writers.frozen >= level)) {
>  		if (!wait)
>  			return 0;
> -		wait_event(sb->s_writers.wait_unfrozen,
> +		wait_event_killable(sb->s_writers.wait_unfrozen,
>  			   sb->s_writers.frozen < level);
>  	}
>  
> @@ -1248,7 +1248,7 @@ static void sb_wait_write(struct super_b
>  		 * of frozen and checking of the counter
>  		 */
>  		prepare_to_wait(&sb->s_writers.wait, &wait,
> -				TASK_UNINTERRUPTIBLE);
> +				 TASK_KILLABLE);
>  
>  		writers = percpu_counter_sum(&sb->s_writers.counter[level-1]);
>  		if (writers)
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/