lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Mar 2013 10:34:42 +0900 From: Namjae Jeon <linkinjeon@...il.com> To: Jaegeuk Kim <jaegeuk.kim@...sung.com> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net Subject: Re: [PATCH 4/4] f2fs: fix to give correct parent inode number for roll forward > */ > -static inline void set_cold_file(struct f2fs_sb_info *sbi, struct inode > *inode, > +static inline void set_cold_files(struct f2fs_sb_info *sbi, struct inode > *inode, > const unsigned char *name) > { > int i; > @@ -108,7 +109,7 @@ static inline void set_cold_file(struct f2fs_sb_info > *sbi, struct inode *inode, > int count = le32_to_cpu(sbi->raw_super->extension_count); > for (i = 0; i < count; i++) { > if (!is_multimedia_file(name, extlist[i])) { > - F2FS_I(inode)->i_advise |= FADVISE_COLD_BIT; > + set_cold_file(inode); > break; > } > } It is just my private opinion. How about use this name "set_cold_file_from_list instead of set_cold_files ? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists