linux-kernel - Re: [PATCH v2 02/13] rwsem: shorter spinlocked section in rwsem_down_failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51549416.4000401@redhat.com>
Date:	Thu, 28 Mar 2013 15:03:50 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Michel Lespinasse <walken@...gle.com>
CC:	Alex Shi <alex.shi@...el.com>, Ingo Molnar <mingo@...nel.org>,
	David Howells <dhowells@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yuanhan Liu <yuanhan.liu@...ux.intel.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Dave Chinner <david@...morbit.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/13] rwsem: shorter spinlocked section in rwsem_down_failed_common()

On 03/15/2013 06:54 AM, Michel Lespinasse wrote:
> This change reduces the size of the spinlocked and TASK_UNINTERRUPTIBLE
> sections in rwsem_down_failed_common():
>
> - We only need the sem->wait_lock to insert ourselves on the wait_list;
>    the waiter node can be prepared outside of the wait_lock.
>
> - The task state only needs to be set to TASK_UNINTERRUPTIBLE immediately
>    before checking if we actually need to sleep; it doesn't need to protect
>    the entire function.
>
> Signed-off-by: Michel Lespinasse <walken@...gle.com>

Reviewed-by: Rik van Riel <riel@...hat.com>

Feel free to keep this Reviewed-by: line across cosmetic
changes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/