lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 31 Mar 2013 23:41:03 -0700
From:	Anton Vorontsov <anton@...msg.org>
To:	Andrei Epure <epure.andrei@...il.com>
Cc:	dwmw2@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: resource_size() instead of computation

On Wed, Mar 27, 2013 at 11:53:47PM +0200, Andrei Epure wrote:
> Patch found using coccinelle.
> 
> Signed-off-by: Andrei Epure <epure.andrei@...il.com>
> ---

Silviu-Mihai Popescu sent a similar patch ealier, but I added your
Signed-off-by to the commit.

>  drivers/power/goldfish_battery.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/goldfish_battery.c b/drivers/power/goldfish_battery.c
> index c10f460..29eba88 100644
> --- a/drivers/power/goldfish_battery.c
> +++ b/drivers/power/goldfish_battery.c
> @@ -178,7 +178,7 @@ static int goldfish_battery_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  	}
>  
> -	data->reg_base = devm_ioremap(&pdev->dev, r->start, r->end - r->start + 1);
> +	data->reg_base = devm_ioremap(&pdev->dev, r->start, resource_size(r));
>  	if (data->reg_base == NULL) {
>  		dev_err(&pdev->dev, "unable to remap MMIO\n");
>  		return -ENOMEM;
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ