linux-kernel - Re: [PATCH resend] pinctrl: core: add dependence of GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Apr 2013 13:49:59 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Haojian Zhuang <haojian.zhuang@...aro.org>
Cc:	Fengguang Wu <fengguang.wu@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Patch Tracking <patches@...aro.org>
Subject: Re: [PATCH resend] pinctrl: core: add dependence of GPIOLIB

On Thu, Mar 28, 2013 at 12:34 AM, Haojian Zhuang
<haojian.zhuang@...aro.org> wrote:

> In file included from drivers/pinctrl/core.c:30:0:
> include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep':
> include/asm-generic/gpio.h:270:2: error: implicit declaration of
> function '__gpio_get_value' [-Werror=implicit-function-declaration]
> include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep':
> include/asm-generic/gpio.h:276:2: error: implicit declaration of
> function '__gpio_set_value' [-Werror=implicit-function-declaration]
> drivers/pinctrl/core.c: In function 'pinctrl_ready_for_gpio_range':
> drivers/pinctrl/core.c:297:9: error: implicit declaration of function
> 'gpio_to_chip' [-Werror=implicit-function-declaration]
> drivers/pinctrl/core.c:297:27: warning: initialization makes pointer
> from integer without a cast [enabled by default]
> drivers/pinctrl/core.c:304:45: error: dereferencing pointer to
> incomplete type
> drivers/pinctrl/core.c:305:26: error: dereferencing pointer to
> incomplete type
> drivers/pinctrl/core.c:305:39: error: dereferencing pointer to
> incomplete type
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/pinctrl/core.o] Error 1
> make[1]: *** [drivers/pinctrl] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> It's caused by CONFIG_GPIOLIB isn't enabled for some platform. So
> add the dependence on pinctrl_ready_for_gpio_range().
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@...aro.org>

Patch applied, thanks!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/